ImmutableIntList of four does not store 2nd and 3rd element correctly.#681
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
wilx
force-pushed
the
master-immutable-list-of-three
branch
from
81312a7 to
5197132
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
|
FYI, I did sign the CLA. |
|
Ping. Is it really that hard to get this simple fix in? |
MicWalter
left a comment
MicWalter
left a comment
There was a problem hiding this comment.
Nice catch! Hopefully my approval is accepted
MicWalter
force-pushed
the
master-immutable-list-of-three
branch
from
5197132 to
23c918d
Compare
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
|
I re-signed the CLA. It should be OK now. |
|
@cla-bot check |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilx on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Kinda embarrassed to ask this of you, but can you please sign one last time. We improved the pipeline so that now the process doesn't depend on one person (so I can add you to the list). |
Done. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
Thanks @wilx for your contribution. Sorry for not getting to merge this for a long time. |
3 participants
Description
There appears to be a defect in
ImmutableIntList#of(int, int, int, int...). It does not actually store 2nd and 3rd item correctly.Related Issue
Type of Change
Checklist